Wand Cap and Core Refactor #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce the LP cost for the blood cores' regen and cause the Weakness 3 effect when used as a weapon just like the Alchemical Caps.
Blood Wood Cores already match the .startsWith("blood") for the Weakness check and have their own logic for blood iron caps, so nothing needs to be changed to support them.
Clean up c-style array declarations Use enhanced for loops Rename ignored exception variables and remove redundant returns
Nikolay-Sitnikov
approved these changes
Aug 14, 2025
Nikolay-Sitnikov
left a comment
Nikolay-Sitnikov
left a comment
There was a problem hiding this comment.
You might also want to put the ItemWandCasting into a variable in these functions, but that's up to you.
src/main/java/fox/spiteful/forbidden/items/wands/BloodStaffUpdate.java
Outdated
Show resolved
Hide resolved
src/main/java/fox/spiteful/forbidden/items/wands/BloodStaffUpdate.java
Outdated
Show resolved
Hide resolved
src/main/java/fox/spiteful/forbidden/items/wands/BloodWandUpdate.java
Outdated
Show resolved
Hide resolved
src/main/java/fox/spiteful/forbidden/items/wands/CreativeWandUpdate.java
Outdated
Show resolved
Hide resolved
src/main/java/fox/spiteful/forbidden/items/wands/ManaStaffUpdate.java
Outdated
Show resolved
Hide resolved
Nikolay-Sitnikov
requested changes
Aug 14, 2025
Nikolay-Sitnikov
left a comment
Nikolay-Sitnikov
left a comment
There was a problem hiding this comment.
Whoops, chose wrong option while filing the review.
…w superclass Cache max vis checks Unroll some if blocks Replace Throwable with Exception Fix position rounding for tainted rod Use ternary operators where relevant Replace repeated profane contract requests with a local variable
Member
Dream-Master
added
the
🚧 Testing on Zeta
sisyphussy
reviewed
Oct 7, 2025
koolkrafter5
added
the
safe for stable
Nikolay-Sitnikov
requested changes
Oct 8, 2025
src/main/java/fox/spiteful/forbidden/items/wands/ProfaneWandUpdate.java
Outdated
Show resolved
Hide resolved
src/main/java/fox/spiteful/forbidden/items/wands/InfernalWandUpdate.java
Outdated
Show resolved
Hide resolved
src/main/java/fox/spiteful/forbidden/items/wands/InfernalWandUpdate.java
Show resolved
Hide resolved
src/main/java/fox/spiteful/forbidden/items/wands/CreativeWandUpdate.java
Show resolved
Hide resolved
src/main/java/fox/spiteful/forbidden/items/wands/ManaStaffUpdate.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Nikolay S. <nicksitnikov@gmail.com>
koolkrafter5
changed the title
Some still check against the name, notably blood_iron from Blood Arsenal and ones that check if the name *starts with* a certain phrase, like .startsWith("blood") to match multiple different cores.
Nikolay-Sitnikov
approved these changes
Oct 11, 2025
Nikolay-Sitnikov
left a comment
Nikolay-Sitnikov
left a comment
There was a problem hiding this comment.
Other than one code design question, all is good.
|
|
||
| @Override | ||
| protected int regenTimer() { | ||
| return 40; |
There was a problem hiding this comment.
Perhaps regenTimer should be a field that is set in the base constructor, instead of being an overrideable method?
Dream-Master
removed
the
🚧 Testing on Zeta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blood Iron Caps now reduce the LP cost for the blood cores' regen and cause the Weakness 3 effect when used as a weapon, just like the Alchemical Caps.
Blood Wood Cores already match the .startsWith("blood") for the Weakness check and have their own logic for Blood Iron Caps, so nothing needs to be changed to support them.
Also cleaned up all of the wand update classes.