Fixing the crash of loading the map if the world has a height above 255 blocks

[MrLeonardosVoid]

There was a problem that if the height in the code was greater than 255 in any of the worlds, then under some circumstances the loading of this world crashed and it was impossible to restart it before rebooting, but now we render strictly from 0 to 255. We have enough of this limitation, since there is no support for the height of the world above this limit in any of the cores.

[dvdmandt]

Hi, and thanks for taking the time to make this PR! Can you tell me more about the problem this solves? As far as I can tell, all relevant methods already have if(y > 255) checks, so what are the circumstances where this solves something? Do you have logs with callstacks?

I'm not entirely sure, but I think that the only scenarios where these extra checks and caps would actually do anything is if there's a bug in another area, in which case this will mask the real issue. Since this is some of the hotter code paths, I'd prefer to fix the issue where the structures are setup rather than do extensive checking for every pixel and step in these methods if possible.

[boubou19]

@MrLeonardosVoid any news?