Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the Guild Wars 2 markup parser for better performance, particularly for text-only inputs which see a ~2x improvement. The changes refactor the main parsing loop to reduce string allocations and regex operations without changing the parser's behavior.
Changes:
- Replaced the
currentChildren()helper function with a trackedchildrenvariable that's updated when pushing/popping from the stack - Optimized character-by-character processing by peeking at
value[i]before doing expensive string slicing and regex matching - Replaced regex-based search for next nodes with faster
indexOfcalls for<and\ncharacters
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/parser/src/parser.ts | Refactored main parsing loop with performance optimizations: tracks children array as variable, peeks at characters before regex matching, uses indexOf for finding next nodes |
| .changeset/silly-symbols-own.md | Added changeset documenting the performance improvement as a patch release |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doubles the performance for text only inputs, and is also quite a bit faster for other markup.
Before
After
Changes
value.slice(i)on every iteration, instead work withvalue[i]if possibleindexOfinstead of regex search to find next potential node