Align build with react/solid/… instead of svelte | fix default error typing | add simple example | add mutation controller#1
Open
JulianCataldo wants to merge 6 commits intoGabswim:feat/lit-query-examplefrom
Conversation
See ```ts if (error) return 'An error has occurred: ' + error.message ``` in react/simple example
f0522b0 to
9e709ce
Compare
Author
|
Added a working "lit simple" example + fixed a typing mismatch. It looks like react-query is using |
Was using `unknown` at the beginning. It's now aligned with others implementations.
Author
|
Added a mutation observer controller, with correct typings (from react-query etc.) @customElement('child-element')
export class ChildElement extends LitElement {
@state() todoId = 1
private todoQuery = todoQueryController(this)
private todoMutation = new MutationController(this, () => ({
mutationFn: (newTodo: { id: string }) => {
console.log('OK')
return new Promise((r) => r({}))
},
}))
render() {
const { isPending, error, data, isFetching } = this.todoQuery.result
if (error) return 'An error has occurred: ' + error.message
return html`
<button
@click=${() => {
this.todoMutation.result.mutate(
{ id: 'string' },
{
onSuccess: () => {
console.log('OK')
queryClient.invalidateQueries({ queryKey: ['todo'] })
},
},
)
}}
>
MUTATE
</button>
`
//...
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi :) Thanks for chiming in making Lit compatible with React Query!
This fixes build, so the root nx command,
build:all, can succeed.