[Backend] Role-Based Control Guards for Route Scopes#312
Open
armorbreak001 wants to merge 1 commit intoGalactiGuild:mainfrom
Open
[Backend] Role-Based Control Guards for Route Scopes#312armorbreak001 wants to merge 1 commit intoGalactiGuild:mainfrom
armorbreak001 wants to merge 1 commit intoGalactiGuild:mainfrom
Conversation
- Import RoleGuard, Roles decorator, UserRole into BountyController - PATCH /bounties/:id (update) → ADMIN only - POST /bounties/:id/cancel → ADMIN only - POST /bounties/:id/review-work → ADMIN only - POST /:id/applications/:appId/review → ADMIN or MODERATOR - POST /:id/milestones/:mid/approve → ADMIN or MODERATOR - Non-admin users receive 403 Forbidden on protected endpoints Fixes GalactiGuild#296
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #296
Changes
RoleGuard+@Roles(...)to all mutating endpoints:PATCH /bounties/:id(update) → ADMIN onlyPOST /bounties/:id/cancel→ ADMIN onlyPOST /bounties/:id/review-work→ ADMIN onlyPOST /bounties/:id/applications/:appId/review→ ADMIN or MODERATORPOST /bounties/:id/milestones/:mid/approve→ ADMIN or MODERATOR403 ForbiddenresponseAcceptance Criteria Met
@Roles(...roles)decorator assigning acceptable criteria array strings (already existed — now applied)RolesGuardexamining ExecutionCtx payload reflecting User roles (already existed — now applied)/bounties/:idmutating patches exclusively to ADMIN (and MODERATOR for review endpoints)How to Verify
PATCH /bounties/:idwith USER token → 403 ForbiddenPATCH /bounties/:idwith ADMIN token → success