[Backend] Implement Environment Config Validation Guard#315
Open
armorbreak001 wants to merge 1 commit intoGalactiGuild:mainfrom
Open
[Backend] Implement Environment Config Validation Guard#315armorbreak001 wants to merge 1 commit intoGalactiGuild:mainfrom
armorbreak001 wants to merge 1 commit intoGalactiGuild:mainfrom
Conversation
- Add joi dependency for schema validation - Add validationSchema to ConfigModule.forRoot in AppModule - Required: PORT (default 3000), DATABASE_URL, JWT_SECRET (min 16 chars) - Optional: REDIS_HOST, REDIS_PORT, REDIS_URL - On missing/invalid env vars → NestJS hard crash with clear error message - abortEarly: false to show all validation errors at once Fixes GalactiGuild#292
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #292
Changes
joidependencyvalidationSchemausing JoiPORT: number, defaults to 3000DATABASE_URL: required — connection string for PostgreSQLJWT_SECRET: required, minimum 16 characters (with custom error message)REDIS_HOST/PORT/URL: optional (for queue interactions)abortEarly: false— reports all validation errors at once, not just the firstallowUnknown: true— permits additional env vars without errorBehavior
On startup, if any required env var is missing or invalid:
"Missing Configuration: JWT_SECRET"or similarprocess.exit(1)handled by NestJS bootstrap)Acceptance Criteria Met
How to Verify
JWT_SECRETfrom.envnpm run start:dev"Missing Configuration: JWT_SECRET"JWT_SECRET→ server starts normally