Retry failed downloads, rather than crashing#12
Open
fancyfinn9 wants to merge 3 commits intoGalaxy1036:masterfrom
Open
Retry failed downloads, rather than crashing#12fancyfinn9 wants to merge 3 commits intoGalaxy1036:masterfrom
fancyfinn9 wants to merge 3 commits intoGalaxy1036:masterfrom
Conversation
Previous behaviour: If an error occurs while downloading, the program crashes (due to no error handling) New behaviour: If an error occurs while downloading, the program will retry the download, up to an amount specified in the settings. If it still can't download the file it will gracefully stop the download and notify the user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ui.download_widget.DownloadWidget.on_donwload_finishtoui.download_widget.DownloadWidget.on_download_finish