Fix up the solver version probe logic#3082
Merged
sauclovian-g merged 2 commits intomasterfrom Mar 5, 2026
Merged
Conversation
sauclovian-g
requested review from
RyanGlScott,
brianhuffman and
chathhorn-galois
RyanGlScott
reviewed
Mar 4, 2026
Use panic, not error, if one comes through.
sauclovian-g
force-pushed
the
fix-solver-version-probes
branch
from
88da91c to
ec93b72
Compare
This is probably what caused What4 to get left off the list in the original version of the previous commit. In any event, it's more readable this way.
RyanGlScott
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid generating version requests for solvers we don't support.
Use panic, not error, if one comes through.
If this code looks familiar, it's because it first appeared on the #2976 branch. That isn't going to be merged for a while though because it depends on the deprecation cycle; this cleanup can and should go in right away.