Migrate imports of foldl' for ghc 9.10+#3146
Merged
sauclovian-g merged 2 commits intomasterfrom Apr 8, 2026
Merged
Conversation
sauclovian-g
requested review from
RyanGlScott,
brianhuffman and
chathhorn-galois
RyanGlScott
approved these changes
Apr 8, 2026
Comment on lines
+277
to
+279
| -- XXX: why do we need to hide maximum? the word does not appear in | ||
| -- this file except in comments... | ||
| import Prelude hiding (Foldable(..), maximum) |
Contributor
There was a problem hiding this comment.
I think this is a leftover from back when SAW supported a much earlier version of GHC that defined separate maximum functions in the Prelude vs Data.Foldable. Now that both functions are the same, we could likely drop the hiding (maximum) bit.
Contributor
Author
There was a problem hiding this comment.
Good to know, I'll dump it.
sauclovian-g
force-pushed
the
foldl-migration
branch
from
ce4702d to
305a765
Compare
Contributor
Author
|
(rebased on head) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by:
https://discourse.haskell.org/t/prelude-foldl-migration-guide/6950
Test-built on #2973, but may as well get merged right away.