minimal changes for testing sbv 14#3177
Draft
danmatichuk wants to merge 4 commits intomasterfrom
Draft
Conversation
RyanGlScott
reviewed
Apr 24, 2026
Contributor
RyanGlScott
left a comment
There was a problem hiding this comment.
Nice! That wasn't as bad as I was fearing.
It's a pity that newer version of sbv won't build with GHC 9.4 or 9.6, but there's not much we can do about that on our side, I suppose.
| -- enable ghc >= 9.8's additional build parallelism | ||
| semaphore: true | ||
|
|
||
| allow-newer: sbv |
Contributor
There was a problem hiding this comment.
Presumably this is here because of the upper version bounds in cryptol, I presume? Are you planning to do a corresponding PR on the cryptol side?
Contributor
Author
There was a problem hiding this comment.
Yes exactly, I'll take a look at cryptol shortly but given this I suspect it will be straightforward.
Contributor
There was a problem hiding this comment.
JFTR, this was addressed in GaloisInc/cryptol#2032.
Contributor
|
...and it seems sbv 14.1 appeared today... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.