Preserve more Cryptol numeric predicates in SAWCore types#3202
Draft
brianhuffman wants to merge 10 commits intomasterfrom
Draft
Preserve more Cryptol numeric predicates in SAWCore types#3202brianhuffman wants to merge 10 commits intomasterfrom
brianhuffman wants to merge 10 commits intomasterfrom
Conversation
`PEqual` is no longer one of the "erased" proposition types in the Cryptol importer, which means that any Cryptol function whose type schema includes a numeric equality constraint will now have that constraint as an argument in its SAWCore type.
The type of ecFromThenTo in Cryptol.sawcore has changed.
This is just for completeness, as `PTrue` should never actually show up in any type-checked Cryptol terms.
`PGeq` is no longer one of the "erased" proposition types in the Cryptol importer, which means that any Cryptol function whose type schema includes a numeric inequality constraint will now have that constraint as an argument in its SAWCore type.
Changes are caused by additions to Cryptol.sawcore.
brianhuffman
force-pushed
the
bh/cryptol-preserve-props
branch
2 times, most recently
from
355874a to
a91522a
Compare
Any Cryptol function whose type schema includes a numeric inequality constraint will now have that constraint as an argument in its SAWCore type.
Any cryptol function whose type includes a `fin` constraint will now have that constraint as an argument in its SAWCore type.
Translated Cryptol expressions now include proofs for `fin` constraints.
This exercises the import of all Cryptol numeric sequence primitives.
brianhuffman
force-pushed
the
bh/cryptol-preserve-props
branch
from
a91522a to
dd64670
Compare
Contributor
Author
|
The SAW-exercises test is failing on a call to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP