Conversation
Factors out uninterpreted code into a separate modules, and reworks the code to use the same code path for both the rount-trip and non-round-trip variants of the code. This allows us to use the sharing uninterpreted functions implementation in both cases, which fixes #3195. The code seems to have also fixed #3166, I think, because we don't have a special case for 0 arity functions.
RyanGlScott
reviewed
May 4, 2026
RyanGlScott
approved these changes
May 5, 2026
sauclovian-g
reviewed
May 5, 2026
| case arrT of | ||
|
|
||
| -- Special case for when reinterpreting uninterpreted functions. | ||
| -- Thechnically, this is just an optimization (i.e., we could |
Contributor
There was a problem hiding this comment.
Suggested change
| -- Thechnically, this is just an optimization (i.e., we could | |
| -- Technically, this is just an optimization (i.e., we could |
Another typo :-(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Factors out uninterpreted code into a separate modules, and reworks the code to use the same code path for both the rount-trip and non-round-trip variants of the code.
This allows us to use the sharing uninterpreted functions implementation in both cases, which fixes #3195.
The code seems to have also fixed #3166, I think, because we don't have a special case for 0 arity functions.