This repository was archived by the owner on Oct 4, 2023. It is now read-only.
chore: move code from galoy-client to graphql-codegen (Julian)#174
Draft
chore: move code from galoy-client to graphql-codegen (Julian)#174
Conversation
Contributor
Author
|
Instructions to run web wallet in readme.md, but here is the config to connect to staging:
|
6713278 to
9e0392f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to move away from using the
Galoy clientas a dependency. This is a separate package that makes graphql api calls...but it is very hard to maintain because our codebase is constantly changing. The web wallet is pinned to version 0.1.62 due to breaking changes in later versions.https://github.com/GaloyMoney/galoy-client/tree/0.1.62/
The big idea is to remove the dependency on
Galoy Clientand move to the npm package@graphql-codegenhttps://the-guild.dev/graphql/codegen. This lib can generate types and react hooks based on a graphql schema. This is beneficial because we can move fast and generate new types on the fly when the code base changes. It also generates
useQueryhooks that will automatically query the graphql api