Skip to content

Crossbow Cartridges - Fix torch place fail playing placement sound #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
runcows wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Crossbow Cartridges - Fix torch place fail playing placement sound #1231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gm4_crossbow_cartridges/data/gm4_crossbow_cartridges/function/init.mcfunction
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scoreboard objectives add gm4_cb_string dummy
scoreboard objectives add gm4_cb_tw_hook dummy
scoreboard objectives add gm4_cb_tw_length dummy
scoreboard objectives add gm4_cb_misc dummy

execute unless score crossbow_cartridges gm4_modules matches 1 run data modify storage gm4:log queue append value {type:"install",module:"Crossbow Cartridges"}
execute unless score crossbow_cartridges gm4_earliest_version < crossbow_cartridges gm4_modules run scoreboard players operation crossbow_cartridges gm4_earliest_version = crossbow_cartridges gm4_modules
Expand Down
11 changes: 6 additions & 5 deletions ...cartridges/data/gm4_crossbow_cartridges/function/projectile/copper_torch/check.mcfunction
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,17 @@
# run from projectile/copper_torch/loop

# summon torch item if torch already exists at this block
execute if block ~ ~ ~ #gm4_crossbow_cartridges:torch run loot spawn ~ ~ ~ loot minecraft:blocks/copper_torch
execute if block ~ ~ ~ #gm4_crossbow_cartridges:torch store success score $dropped_item gm4_cb_misc run loot spawn ~ ~ ~ loot minecraft:blocks/copper_torch

# place torch if possible
execute if block ~ ~ ~ #gm4:replaceable run function gm4_crossbow_cartridges:projectile/copper_torch/place

# summon torch item if placing torch failed
execute unless block ~ ~ ~ #gm4_crossbow_cartridges:torch run loot spawn ~ ~ ~ loot minecraft:blocks/copper_torch
execute unless block ~ ~ ~ #gm4_crossbow_cartridges:torch store success score $dropped_item gm4_cb_misc run loot spawn ~ ~ ~ loot minecraft:blocks/copper_torch

# place block sound
playsound minecraft:block.wood.place block @a[distance=..15]
# item drop sound
execute if score $dropped_item gm4_cb_misc matches 1 run playsound minecraft:entity.item.pickup block @a[distance=..15]

# kill arrow
# clean up
scoreboard players reset $dropped_item gm4_cb_misc
kill @s
3 changes: 3 additions & 0 deletions ...cartridges/data/gm4_crossbow_cartridges/function/projectile/copper_torch/place.mcfunction
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@ execute positioned ~ ~ ~.1 if predicate gm4_crossbow_cartridges:check_block/sout
execute positioned ~-.1 ~ ~ if predicate gm4_crossbow_cartridges:check_block/west run setblock ~.15 ~ ~ minecraft:copper_wall_torch[facing=east]
execute positioned ~ ~ ~-.1 if predicate gm4_crossbow_cartridges:check_block/north run setblock ~ ~ ~.15 minecraft:copper_wall_torch[facing=south]
execute positioned ~ ~-.1 ~ if predicate gm4_crossbow_cartridges:check_block/below run setblock ~ ~.15 ~ minecraft:copper_torch

# place block sound
execute if block ~ ~ ~ #gm4_crossbow_cartridges:torch run playsound minecraft:block.wood.place block @a[distance=..15]
11 changes: 6 additions & 5 deletions ...rtridges/data/gm4_crossbow_cartridges/function/projectile/redstone_torch/check.mcfunction
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,17 @@
# run from projectile/redstone_torch/loop

# summon torch item if torch already exists at this block
execute if block ~ ~ ~ #gm4_crossbow_cartridges:torch run loot spawn ~ ~ ~ loot minecraft:blocks/redstone_torch
execute if block ~ ~ ~ #gm4_crossbow_cartridges:torch store success score $dropped_item gm4_cb_misc run loot spawn ~ ~ ~ loot minecraft:blocks/redstone_torch

# place torch if possible
execute if block ~ ~ ~ #gm4:replaceable run function gm4_crossbow_cartridges:projectile/redstone_torch/place

# summon torch item if placing torch failed
execute unless block ~ ~ ~ #gm4_crossbow_cartridges:torch run loot spawn ~ ~ ~ loot minecraft:blocks/redstone_torch
execute unless block ~ ~ ~ #gm4_crossbow_cartridges:torch store success score $dropped_item gm4_cb_misc run loot spawn ~ ~ ~ loot minecraft:blocks/redstone_torch

# place block sound
playsound minecraft:block.wood.place block @a[distance=..15]
# item drop sound
execute if score $dropped_item gm4_cb_misc matches 1 run playsound minecraft:entity.item.pickup block @a[distance=..15]

# kill arrow
# clean up
scoreboard players reset $dropped_item gm4_cb_misc
kill @s
3 changes: 3 additions & 0 deletions ...rtridges/data/gm4_crossbow_cartridges/function/projectile/redstone_torch/place.mcfunction
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@ execute positioned ~ ~ ~.1 if predicate gm4_crossbow_cartridges:check_block/sout
execute positioned ~-.1 ~ ~ if predicate gm4_crossbow_cartridges:check_block/west run setblock ~.15 ~ ~ minecraft:redstone_wall_torch[facing=east]
execute positioned ~ ~ ~-.1 if predicate gm4_crossbow_cartridges:check_block/north run setblock ~ ~ ~.15 minecraft:redstone_wall_torch[facing=south]
execute positioned ~ ~-.1 ~ if predicate gm4_crossbow_cartridges:check_block/below run setblock ~ ~.15 ~ minecraft:redstone_torch

# place block sound
execute if block ~ ~ ~ #gm4_crossbow_cartridges:torch run playsound minecraft:block.wood.place block @a[distance=..15]
11 changes: 6 additions & 5 deletions ...w_cartridges/data/gm4_crossbow_cartridges/function/projectile/soul_torch/check.mcfunction
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,17 @@
# run from projectile/soul_torch/loop

# summon torch item if torch already exists at this block
execute if block ~ ~ ~ #gm4_crossbow_cartridges:torch run loot spawn ~ ~ ~ loot minecraft:blocks/soul_torch
execute if block ~ ~ ~ #gm4_crossbow_cartridges:torch store success score $dropped_item gm4_cb_misc run loot spawn ~ ~ ~ loot minecraft:blocks/soul_torch

# place torch if possible
execute if block ~ ~ ~ #gm4:replaceable run function gm4_crossbow_cartridges:projectile/soul_torch/place

# summon torch item if placing torch failed
execute unless block ~ ~ ~ #gm4_crossbow_cartridges:torch run loot spawn ~ ~ ~ loot minecraft:blocks/soul_torch
execute unless block ~ ~ ~ #gm4_crossbow_cartridges:torch store success score $dropped_item gm4_cb_misc run loot spawn ~ ~ ~ loot minecraft:blocks/soul_torch

# place block sound
playsound minecraft:block.wood.place block @a[distance=..15]
# item drop sound
execute if score $dropped_item gm4_cb_misc matches 1 run playsound minecraft:entity.item.pickup block @a[distance=..15]

# kill arrow
# clean up
scoreboard players reset $dropped_item gm4_cb_misc
kill @s
3 changes: 3 additions & 0 deletions ...w_cartridges/data/gm4_crossbow_cartridges/function/projectile/soul_torch/place.mcfunction
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@ execute positioned ~ ~ ~.1 if predicate gm4_crossbow_cartridges:check_block/sout
execute positioned ~-.1 ~ ~ if predicate gm4_crossbow_cartridges:check_block/west run setblock ~.15 ~ ~ minecraft:soul_wall_torch[facing=east]
execute positioned ~ ~ ~-.1 if predicate gm4_crossbow_cartridges:check_block/north run setblock ~ ~ ~.15 minecraft:soul_wall_torch[facing=south]
execute positioned ~ ~-.1 ~ if predicate gm4_crossbow_cartridges:check_block/below run setblock ~ ~.15 ~ minecraft:soul_torch

# place block sound
execute if block ~ ~ ~ #gm4_crossbow_cartridges:torch run playsound minecraft:block.wood.place block @a[distance=..15]
11 changes: 6 additions & 5 deletions ...ossbow_cartridges/data/gm4_crossbow_cartridges/function/projectile/torch/check.mcfunction
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,17 @@
# run from projectile/torch/loop

# summon torch item if torch already exists at this block
execute if block ~ ~ ~ #gm4_crossbow_cartridges:torch run loot spawn ~ ~ ~ loot minecraft:blocks/torch
execute if block ~ ~ ~ #gm4_crossbow_cartridges:torch store success score $dropped_item gm4_cb_misc run loot spawn ~ ~ ~ loot minecraft:blocks/torch

# place torch if possible
execute if block ~ ~ ~ #gm4:replaceable run function gm4_crossbow_cartridges:projectile/torch/place

# summon torch item if placing torch failed
execute unless block ~ ~ ~ #gm4_crossbow_cartridges:torch run loot spawn ~ ~ ~ loot minecraft:blocks/torch
execute unless block ~ ~ ~ #gm4_crossbow_cartridges:torch store success score $dropped_item gm4_cb_misc run loot spawn ~ ~ ~ loot minecraft:blocks/torch

# place block sound
playsound minecraft:block.wood.place block @a[distance=..15]
# item drop sound
execute if score $dropped_item gm4_cb_misc matches 1 run playsound minecraft:entity.item.pickup block @a[distance=..15]

# kill arrow
# clean up
scoreboard players reset $dropped_item gm4_cb_misc
kill @s
3 changes: 3 additions & 0 deletions ...ossbow_cartridges/data/gm4_crossbow_cartridges/function/projectile/torch/place.mcfunction
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@ execute positioned ~ ~ ~.1 if predicate gm4_crossbow_cartridges:check_block/sout
execute positioned ~-.1 ~ ~ if predicate gm4_crossbow_cartridges:check_block/west run setblock ~.15 ~ ~ minecraft:wall_torch[facing=east]
execute positioned ~ ~ ~-.1 if predicate gm4_crossbow_cartridges:check_block/north run setblock ~ ~ ~.15 minecraft:wall_torch[facing=south]
execute positioned ~ ~-.1 ~ if predicate gm4_crossbow_cartridges:check_block/below run setblock ~ ~.15 ~ minecraft:torch

# place block sound
execute if block ~ ~ ~ #gm4_crossbow_cartridges:torch run playsound minecraft:block.wood.place block @a[distance=..15]
Loading