-
-
Notifications
You must be signed in to change notification settings - Fork 64
PS11 Resource Pack PR merge #1234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
runcows
wants to merge
207
commits into
Gamemode4Dev:master
Choose a base branch
from
runcows:ps11-resource-pack-combo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into pr/TheThanathor/896
- furniture station displays sticking around (they'll need to be re placed) - furniture station villagers still having gm4_new_furniture
- I should be asleep - Addressed all of the concerns Beeps had - Should have checked again at literally any point because this really was not much
- Before putting it onto public server
This will make all items appear as missing textures. It's possible to make them look like leather armor without the RP, but making the item sprites missing textures should "force" the RP to be required. This is important because without the RP the armor is invisible, so we should highly discourage that by making the item textures missing without the RP. I.e. make it basically unplayable without the RP so people don't get invisible armor
Add custom armor assets (RP required)
…into furniture_1.21.8
…32/GM4_Datapacks into ps11-resource-pack-combo
…apacks into ps11-resource-pack-combo
…_Datapacks into ps11-resource-pack-combo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE !
This PR combines #1036 , #1137 , #1158 for the purposes of using on the public server resource pack.