Open
Conversation
RasmusAntons
force-pushed
the
time_limit
branch
from
845a650 to
7265575
Compare
common/src/main/java/io/github/gaming32/bingo/BingoCommand.java
Outdated
Show resolved
Hide resolved
common/src/main/java/io/github/gaming32/bingo/BingoCommand.java
Outdated
Show resolved
Hide resolved
common/src/main/java/io/github/gaming32/bingo/BingoCommand.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds another start parameter
--time <total time in minutes>and a new commandbingo time set <remaining time in minutes>to set a countdown that will end the game when it reaches 0.For modded clients, the countdown is shown below the board, for vanilla clients it's shown as a boss bar.
I don't know if the command syntax is ideal, i thought about having a more elaborate command like
--time <value> <time unit>.I had to convert the
ClientGamerecord into a class which might be a bit messy.closes #27