Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds sample HAR and DAR files to the samples/ folder, updates .gitignore to include these examples, and enhances the README with commands to inspect them.
- Introduce
samples/example.haras a minimal HAR example. - Introduce
samples/example.daras a minimal DAR example. - Update README to show how to view sample files with
lessandjq.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| samples/example.har | Add a minimal HAR example with empty entries. |
| samples/example.dar | Add a minimal DAR example including a render. |
| README.md | Add instructions for inspecting samples via CLI. |
Comments suppressed due to low confidence (1)
README.md:50
- [nitpick] This paragraph is no longer formatted as a list item under the Examples section. Consider prefixing it with a dash or indenting it consistently to match the surrounding markdown list style.
Check the `samples/` directory for example `.har` and `.dar` files. These samples let you try the converter and inspect DAR output immediately. To view them from the command line:
| "renders": [ | ||
| { | ||
| "url": "https://example.com", | ||
| "status": "200", |
There was a problem hiding this comment.
The HTTP status code is represented as a string here, but the DAR schema (and HAR conventions) expect a numeric value. Change it to a number (e.g., 200) for consistency.
Suggested change
| "status": "200", | |
| "status": 200, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitignoreexamples.harandexample.darin newsamples/folderTesting
PYTHONPATH=. python tests/test_converter.pyPYTHONPATH=. python tests/test_dar_parser.pyhttps://chatgpt.com/codex/tasks/task_e_6840809bdfe483338234d24c28361f79