Add DAR JSON schema and validator update#7
Open
KristopherKubicki wants to merge 1 commit intomasterfrom
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances DAR file validation by introducing a JSON schema and integrating jsonschema-based validation into dar_validator.py. Key changes include:
- Adding dar.schema.json to define the DAR file structure.
- Updating DARValidator to accept an optional schema path and perform schema validation.
- Adding documentation in docs/validation.md and updating the README.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/validators/dar_validator.py | Updated to use jsonschema for validation and support an optional schema path. |
| docs/validation.md | New documentation outlining how to validate DAR files. |
| dar.schema.json | New JSON Schema file defining the DAR file structure. |
| README.md | Updated to include a link to the validation guide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dar.schema.jsondescribing DAR file structuredar_validator.pyTesting
PYTHONPATH=. pytest -qpython -m py_compile tools/validators/dar_validator.pyhttps://chatgpt.com/codex/tasks/task_e_684080a071388333b312075649f81533