only filter keys if jsonschema will complain#137
Merged
OwenPriceSkelly merged 2 commits intomainfrom Apr 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dogfooding against the polaris endpoint, ran into the following scenario: the endpoint schema was just the permissive default with
additionalProperties: trueand did not actually enumerate the keys it required, likequeueorwalltime. this meant that groundhog was dropping the keys silently (since they didn't match the schema), which is correct for anvil but not for others. This changes the behavior to only filter out unexpected keys if the schema will complain