fix: use importlib to get rootstock version spec#25
Open
OwenPriceSkelly wants to merge 1 commit intomainfrom
Open
fix: use importlib to get rootstock version spec#25OwenPriceSkelly wants to merge 1 commit intomainfrom
OwenPriceSkelly wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a quick fix to get myself unblocked on delta, but heads-up: this could cause subtle problems for dev installs if you're expecting a local change to appear in the environment (this now limits us to only installing rootstock from pypi for the rootstock we install in each venv).
I have a more ✨sophisticated✨ util for this exact problem in groundhog to detect if it should install from github using a commit hash instead of pypi; I can reimplement that for rootstock later in a follow-up PR