Skip to content

Conversation

@jboomer007
Copy link

No description provided.

Added Updated Folder Method
@marclaporte
Copy link

@jboomer007

I know it's been a while since your PR. I'd like to clean up list, improve things and get a new release.

Code has changed somewhat since your PR: https://github.com/Garethp/php-ews/commits/master/

Do you think it's still valid?

Thanks!

CC @kambereBr if you can opine)

@kambereBr
Copy link

@jboomer007 are you trying to replace the magic method by removing the @method UpdateFolder($request) annotation (line 78, ExchangeWebServices.php) and adding a concrete updateFolder() method instead?

If so, I’m concerned this would cause a major regression:

  • Current magic method : full UpdateFolder SOAP support (any folder properties)

  • Proposed change : hardcoded to only update DisplayName

That would break code relying on updates to other folder properties.

FYI: Magic method removal has already been started in PR #265, but the goal should be maintaining the same capabilities, not reducing functionality.

Thank you!

@jboomer007
Copy link
Author

jboomer007 commented Aug 27, 2025 via email

@Garethp
Copy link
Owner

Garethp commented Aug 30, 2025

While I think there might be scope to have a simpler method for updating folders, I think a method that updates a single property on a folder might be too narrow-scope to fit in with the simpler API usages that I've built. Taking a look at the other update* type methods that I've written, they tend to accept a wider range of changes rather than targeting specific items. I'm happy to be convinced otherwise, but that would be my take on it at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants