fixed compile error and corrected UI colors#24
Open
lucaji wants to merge 2 commits intoGaudiLabs:mainfrom
Open
fixed compile error and corrected UI colors#24lucaji wants to merge 2 commits intoGaudiLabs:mainfrom
lucaji wants to merge 2 commits intoGaudiLabs:mainfrom
Conversation
|
Hello,
I have tried several things but I can't seem to make this work, sadly... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Urs,
I just tested the code and I can compile it with Arduino IDE without any issues. The GetQMeasurement function is now back in the code and its being used as it was to avoid those drift you mentioned.
Regarding the UI LED colors I do not have the manual here at hand so I went from memory - and did cancel the previous PR as I noticed that the audio should be active at power on (if I remember correctly) and the RED LED indicates the audio active function while the BLUE is on during MUTE state.
Apologies for the delay - it's a busy time for me - hope all is well now, but let me know if any other issues arises.
Cheers,
Luca