fix(cli): include generic auth credentials in permission checks#1
Draft
fix(cli): include generic auth credentials in permission checks#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
genericAuthType, which allowed HTTP Request nodes using generic credential mode to bypass pre-execution project-sharing checks.Description
genericAuthTypeto the set of active credential types inCredentialsPermissionChecker.getActiveCredentialTypesso generic-mode credentials are treated likenodeCredentialTypeand validated before execution.mapCredIdsToNodeswill include credential IDs for types produced bygenericAuthTypethrough the existing active-type filtering.should check generic auth credential type selected by genericAuthTypetopackages/cli/src/executions/pre-execution-checks/__tests__/credentials-permission-checker.test.tsverifying the selected generic credential is passed to accessibility checks.Testing
pnpm build > build.log 2>&1, which completed (build output captured inbuild.log).pnpm testfor the modified test file, but the Jest run failed in this environment due to missing built workspace runtime/test modules (e.g.@n8n/db,@n8n/backend-test-utils) rather than due to assertion failures.pnpm eslintandpnpm typecheckinpackages/cli, which produced only lint warnings and passed type checking withtsc --noEmit.Codex Task