Skip to content

fix(v1.2.3): false-positive "Remove core Downloader" notification#24

Merged
Geek-MD merged 2 commits intomainfrom
copilot/remove-core-downloader-integration
Mar 11, 2026
Merged

fix(v1.2.3): false-positive "Remove core Downloader" notification#24
Geek-MD merged 2 commits intomainfrom
copilot/remove-core-downloader-integration

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 11, 2026

hass.config.components can contain "downloader" at boot even when downloader: is absent from configuration.yaml, causing the conflict notification to fire on every restart for users who never configured the built-in integration.

Changes

  • Reliable detection — replaces "downloader" in hass.config.components with "downloader" in hass.services.async_services(). Services are only registered after a successful async_setup(), making this a true signal that downloader: is explicitly configured.
  • Deferred execution — wraps the check in hass.async_at_start() so it runs after HA has fully started and all YAML integrations have registered their services. Also handles the late-install case (HA already running) automatically.
  • Version bumpmanifest.json1.2.3; CHANGELOG.md updated.
# Before — unreliable, fires even without downloader: in configuration.yaml
if "downloader" in hass.config.components:
    ...

# After — deferred, service-based check
@callback
def _check_downloader_conflict(_: HomeAssistant) -> None:
    if "downloader" in hass.services.async_services():
        ...

hass.async_at_start(_check_downloader_conflict)

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…or downloader conflict detection (v1.2.3)

Co-authored-by: Geek-MD <25725990+Geek-MD@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove core Downloader integration from configuration fix(v1.2.3): false-positive "Remove core Downloader" notification Mar 11, 2026
@Geek-MD Geek-MD marked this pull request as ready for review March 11, 2026 02:49
@Geek-MD Geek-MD merged commit 04c2a12 into main Mar 11, 2026
3 checks passed
@Geek-MD Geek-MD deleted the copilot/remove-core-downloader-integration branch March 11, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants