fix: add types-aiofiles stub to resolve mypy [import-untyped] CI failure#27
Merged
fix: add types-aiofiles stub to resolve mypy [import-untyped] CI failure#27
Conversation
Co-authored-by: Geek-MD <25725990+Geek-MD@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix blocking call warning in advanced_downloader
fix: replace blocking open() with aiofiles for async file writes (v1.2.6)
Mar 18, 2026
…typed error Co-authored-by: Geek-MD <25725990+Geek-MD@users.noreply.github.com>
Co-authored-by: Geek-MD <25725990+Geek-MD@users.noreply.github.com>
Copilot
AI
changed the title
fix: replace blocking open() with aiofiles for async file writes (v1.2.6)
fix: add types-aiofiles stub to resolve mypy [import-untyped] CI failure
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
aiofilesin v1.2.6 introduced a mypy[import-untyped]error in CI — distinct from[import-not-found]and not silenced byignore_missing_imports = Trueinmypy.ini.Changes
requirements.txt— addtypes-aiofiles>=23.1.0so the CIpip install -r requirements.txtstep provides the stubs before mypy runs🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.