fix: Prevent Travel Fix Up injection inside wipe blocks#52
Open
adele-with-a-b wants to merge 1 commit intoGeekDetour:mainfrom
Open
fix: Prevent Travel Fix Up injection inside wipe blocks#52adele-with-a-b wants to merge 1 commit intoGeekDetour:mainfrom
adele-with-a-b wants to merge 1 commit intoGeekDetour:mainfrom
Conversation
BrickLayers was storing travel line references during wipe blocks, then replacing them with Travel Fix Up moves that broke the wipe sequence. Causes missing chunks in Bambu Studio preview and incomplete nozzle wipe at brick layer transitions. One-line fix: added 'and not feature.wiping' check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bambu Studio Wipe Fix
Fixes missing chunks in Bambu Studio's G-code preview and improves print quality at brick layer transitions.
Problem
BrickLayers stores a reference to the last non-internal-perimeter travel line (
last_noninternalperimeter_xy_line) and later replaces it with aTravel Fix Upmove that includes a Z change. When this travel line happens to be inside aWIPE_START/WIPE_ENDblock, the replacement breaks the wipe sequence.This causes:
Fix
One-line change: added
and not feature.wipingcheck when storing the travel line reference. This prevents BrickLayers from modifying travel moves that are part of a wipe sequence.Impact
Slicer Preview
A patched BambuStudio fork is available that re-parses G-code after post-processing scripts run, showing the BrickLayers toolpath directly in the preview without manual re-import. This wipe fix is required for the preview to render correctly.