Open
Conversation
Contributor
Author
|
Thought I'd add the license file in while I was at it. Just plain text. |
| The [Kubernetes cluster name](https://github.com/hashicorp/learn-terraform-eks/blob/master/outputs.tf#L26) and [region](https://github.com/hashicorp/learn-terraform-eks/blob/master/outputs.tf#L21) correspond to the output variables showed after the successful Terraform run. | ||
|
|
||
| You can view these outputs again by running: | ||
|
|
Contributor
There was a problem hiding this comment.
We can delete all the content of the READ.me file from this line onwords as we are not deploying the metric-server and dashboard. In fact we will use other tools for logging and monitoring
Contributor
Author
|
@CarwynNelson and @giulio-giunta May I request your review on this please? |
|
Doesn't the codeowners need to be on a single line? Also is it worth waiting to see how megalinter goes on the |
Contributor
Author
|
fair points both. Let's see how it goes in web |
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #2