Skip to content

Fixed dependency bugs#32

Open
Mohsens22 wants to merge 5 commits intoGeeksltd:masterfrom
Mohsens22:patch-7
Open

Fixed dependency bugs#32
Mohsens22 wants to merge 5 commits intoGeeksltd:masterfrom
Mohsens22:patch-7

Conversation

@Mohsens22
Copy link
Contributor

Fixed dependency bugs reported by @rezacloner47 which was:

The type 'RazorViewAttribute' exists in both 'Microsoft.AspNetCore.Mvc.Razor, Version=2.1.1.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' and 'Microsoft.AspNetCore.Mvc.Razor, Version=2.1.2.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'
+
[assembly:global::Microsoft.AspNetCore.Mvc.Razor.Compilation.RazorViewAttribute(@"/Views/Pages/Login.cshtml", typeof(AspNetCore.Views_Pages_Login))]
The type 'RazorInjectAttribute' exists in both 'Microsoft.AspNetCore.Mvc.Razor, Version=2.1.1.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' and 'Microsoft.AspNetCore.Mvc.Razor, Version=2.1.2.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'
+
        [global::Microsoft.AspNetCore.Mvc.Razor.Internal.RazorInjectAttribute]
The type 'RazorInjectAttribute' exists in both 'Microsoft.AspNetCore.Mvc.Razor, Version=2.1.1.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' and 'Microsoft.AspNetCore.Mvc.Razor, Version=2.1.2.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'
+
        [global::Microsoft.AspNetCore.Mvc.Razor.Internal.RazorInjectAttribute]
The type 'RazorInjectAttribute' exists in both 'Microsoft.AspNetCore.Mvc.Razor, Version=2.1.1.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' and 'Microsoft.AspNetCore.Mvc.Razor, Version=2.1.2.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'
+
        [global::Microsoft.AspNetCore.Mvc.Razor.Internal.RazorInjectAttribute]
The type 'RazorInjectAttribute' exists in both 'Microsoft.AspNetCore.Mvc.Razor, Version=2.1.1.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' and 'Microsoft.AspNetCore.Mvc.Razor, Version=2.1.2.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'
+
        [global::Microsoft.AspNetCore.Mvc.Razor.Internal.RazorInjectAttribute]
The type 'RazorInjectAttribute' exists in both 'Microsoft.AspNetCore.Mvc.Razor, Version=2.1.1.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' and 'Microsoft.AspNetCore.Mvc.Razor, Version=2.1.2.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'
+
        [global::Microsoft.AspNetCore.Mvc.Razor.Internal.RazorInjectAttribute]

on the top of @iPazooki commits in #31 .


<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.App" Version="2.1.2" />
<PackageReference Include="Microsoft.AspNetCore.App" Version="2.1.4" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have update .net core to V2.1.4. in case of merging this PR, we need to update Olive too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I'll do it too.
Because dotnetcore v 2.1.2 causes serious problems for one of our users.

@Mohsens22
Copy link
Contributor Author

Just another note:
This issue is with dotnetcore runtime 2.1.4
So users with that runtime can't run the current M# template which runs 2.1.2 .
So merge this please @PaymonK :D

@PaymonK
Copy link
Contributor

PaymonK commented Sep 15, 2018

Do you mean 2.1.4 runtime is not compatible with 2.1.2 DLLs?!

@Mohsens22
Copy link
Contributor Author

It seems so!
I tested things carefully on @rezacloner47 's machine and V2.1.2 was incompatible with his development environment which was V2.1.4

@Mohsens22
Copy link
Contributor Author

Also this issue is a known bug. A couple of devs reported this in Microsoft's GitHub issues

@Mohsens22
Copy link
Contributor Author

His exact error:
image

Version of dotnet core on his machine ( He runs Windows 10 2018 October update preview):
image

Also a confirmation that these changes work on his machine:
image

@iPazooki
Copy link
Contributor

@Mohsens22 This is not a bug actually. when you install .net core SDK 2.1.4 then you must update all Microsofts.*.dlls in your project, but if you don't you will get your mentioned error.

I mean you are getting this error because you have installed .net core SDK 2.1.4. to get rid of this error you can remove .net 2.1.4 from everywhere by finding its path using dotnet --info and go back to .net core 2.1.2 or you must update all dlls like you have done ;)

the fact is, if we want to update .net core version it should begin by updating Olive and then spread through other projects.

@RezaT4795
Copy link

RezaT4795 commented Sep 16, 2018

@iPazooki Thanks for the hint! :)
Uninstalling .NET Core 2.1.4 could not remove “Microsoft.AspNetCore.All 2.1.4” and “Microsoft.AspNetCore.App 2.1.4” from my system. So running the program, causes a crash.
So I removed those files manually, rebuilt the project and now it works just fine with .NET Core 2.1.2

@iPazooki
Copy link
Contributor

@iPazooki Thanks for the hint! :)
Uninstalling .NET Core 2.1.4 could not remove “Microsoft.AspNetCore.All 2.1.4” and “Microsoft.AspNetCore.App 2.1.4” from my system. So running the program, causes a crash.
So I removed those files manually, rebuilt the project and now it works just fine with .NET Core 2.1.2

Great, that's why I said to use dotnet --info to find all related paths and you should manually remove them all.

Good job ;)

@Mohsens22
Copy link
Contributor Author

Nice

@PaymonK
Copy link
Contributor

PaymonK commented Oct 2, 2018

@iPazooki
Does this PR still need merging, or is it covered by the other ones?

@iPazooki
Copy link
Contributor

iPazooki commented Oct 2, 2018

@iPazooki
Does this PR still need merging, or is it covered by the other ones?

@PaymonK .No, You have already updated the project and this PR is no longer needed.

@PaymonK PaymonK closed this Oct 2, 2018
@PaymonK PaymonK reopened this Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants