Add support for custom json serializer#23
Open
dizballanze wants to merge 1 commit intoGehirnInc:masterfrom
Open
Add support for custom json serializer#23dizballanze wants to merge 1 commit intoGehirnInc:masterfrom
dizballanze wants to merge 1 commit intoGehirnInc:masterfrom
Conversation
yosida95
reviewed
Mar 16, 2020
Member
There was a problem hiding this comment.
@dizballanze Thank you for your contribution!
I think supporting custom JSON implementation is a good idea. But I also think passing loads and dumps every calls of #decode and #encode is troublesome and the users want custom JSON implementation don't switch between the standard JSON and the custom JSON for the each calls.
So, defining json_loads = json.loads and json_dumps = json.dumps as a class variable on JWT and overriding them by an instance variable on the constructer is better. How do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for custom JSON serializers.
This allows to use more efficient JSON serializers like orjson or ujson