fix: Zscaler and Cloudflare WARP not detected in CGNAT IP range#8
Merged
fix: Zscaler and Cloudflare WARP not detected in CGNAT IP range#8
Conversation
Zscaler uses 100.64.x.x which falls in the CGNAT range (100.64.0.0/10). This range was treated as Tailscale-only, so isCorporateVPNIP() called isTailscaleExitNodeActive() which returned false, rejecting the interface. The Cloudflare WARP check (100.96-111) was also dead code since it's a subset of the CGNAT range that returned before reaching it. Fix: pass the process-detection hint into isCorporateVPNIP. When a known non-Tailscale VPN is running, trust it for CGNAT IPs. Only fall back to Tailscale exit-node check when no other VPN process is detected. Closes #7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Zscaler uses
100.64.x.xIPs (CGNAT range), same as Tailscale. The IP validation treated the entire100.64.0.0/10range as Tailscale-only, callingisTailscaleExitNodeActive()which returnedfalse-- rejecting the Zscaler interface asvalid=false.The Cloudflare WARP fallback check (
100.96-111) was also dead code since it's a subset of the CGNAT range that already returned before reaching it.Fix: Pass the process-detection hint into
isCorporateVPNIP(). When a known non-Tailscale VPN process is running (Zscaler, WARP, Check Point, etc.), trust it for CGNAT IPs. Only fall back to Tailscale exit-node check when no specific VPN process was detected.Closes #7
Test plan
100.64.x.xIP is now detected (valid=true)100.96.x.xIP is detected