fix: parallel DNS resolution and robust domain addition#9
Merged
Conversation
DNS resolution was sequential: dig timeouts (~8s) blocked DoH from running when VPN blocks UDP. Now dig and DoH race in parallel with a trust hierarchy — dig-based resolvers fire immediately, DoH fires after a 200ms grace period. First success wins. Resolves in ~2s on VPN instead of 8+. Also fixes addDomain: DNS cache, disk cache, and /etc/hosts are now updated immediately on success (was only done during periodic refresh). DNS failures trigger a tracked 15s auto-retry with fresh gateway lookup, deduplication guards, and proper cancellation on domain removal or VPN disconnect. Additional hardening: - failedDomains changed to Set (prevents unbounded growth) - setAllDomainsEnabled uses single disk write instead of N - toggleDomain now updates hosts file on enable - Redundant MainActor.run wrappers removed (already on MainActor) - isApplyingRoutes properly managed during retries
917df3d to
ecb7ac3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
applyRoutesForDomainnow populatesdnsCacheanddnsDiskCacheimmediately, andaddDomainupdates/etc/hostson success — previously hosts entries were only created during periodic refresh.isApplyingRoutescorrectly.failedDomainschanged toSet(prevents unbounded growth),setAllDomainsEnableddoes a single disk write instead of N,toggleDomainnow updates hosts file, redundantMainActor.runwrappers removed, retry tasks cancelled on VPN disconnect/domain removal.Test plan
/etc/hostsfile populated with domain→IP mappings