-
Notifications
You must be signed in to change notification settings - Fork 21
Use external astrodata instead of repo version #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
teald
wants to merge
11
commits into
master
Choose a base branch
from
feature/external_astrodata
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+424
−13,357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
03d9fa7 to
a840f34
Compare
59d92c5 to
cab5705
Compare
929642b to
895936a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #469 +/- ##
==========================================
- Coverage 64.06% 62.29% -1.77%
==========================================
Files 313 303 -10
Lines 38841 36340 -2501
==========================================
- Hits 24882 22639 -2243
+ Misses 13959 13701 -258
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
windowedOp -> windowed_operation asIRAFsection -> as_iraf_section addClass -> add_class astrodata.open -> astrodata.from_file
895936a to
0bc482c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component - astrodata
astrodata
dependencies
Pull requests that update a dependency file
test
Test suite, regression and integration tests, Jenkins.
usage
Usage and user interfaces
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
astrodata/directory in DRAGONS, as well as references to it in:Related PRs/Releases