Conversation
Airbyte staging tables (e.g. AIRBYTE_SFTP_raw__stream_2025-03-23.csv) have periods in their names, causing warnings.warn to fire once per unique identifier. Switch to logger.debug so the messages are only visible at DEBUG log level. Behaviour is unchanged — the function still returns a value for these identifiers.
2 tasks
…wflaky() Regression guard: verifies the logger.debug branch is actually reached when an identifier has >3 dot-separated parts (e.g. Airbyte staging tables). Without this, a future change back to warnings.warn would go undetected. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
lpillmann
added a commit
that referenced
this pull request
Apr 21, 2026
…in snowflaky() (#16) * fix: replace SyntaxWarning flood in snowflaky() with logger.debug Airbyte staging tables (e.g. AIRBYTE_SFTP_raw__stream_2025-03-23.csv) have periods in their names, causing warnings.warn to fire once per unique identifier. Switch to logger.debug so the messages are only visible at DEBUG log level. Behaviour is unchanged — the function still returns a value for these identifiers. * test: assert debug log fires for period-containing identifiers in snowflaky() Regression guard: verifies the logger.debug branch is actually reached when an identifier has >3 dot-separated parts (e.g. Airbyte staging tables). Without this, a future change back to warnings.warn would go undetected. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
warnings.warn(..., SyntaxWarning)withlogger.debug(...)insnowflaky()for identifiers with more than 3 dot-separated partsAIRBYTE_SFTP_raw__stream_2025-03-23.csv) have periods in their names; each unique table name produced a distinct warning that bypassed Python's deduplication, flooding the interface with hundreds of lines per runDEBUGlog level instead of as a console warningTest Plan
uv run pytest -x --disable-pytest-warnings— 240 tests passtest_snowflakynow useswarnings.catch_warnings()+simplefilter("error")to assert noSyntaxWarningfires fordb16/db17import warningsretained in source (null-identifier branch at line ~389 still uses it)