This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Conversation
lpillmann
approved these changes
May 23, 2025
Collaborator
lpillmann
left a comment
There was a problem hiding this comment.
Looks very good to me!
I like how you also refactored the use of cursors with a context manager instead 👍
Both the implementation and documentation are clear. I left two very minor suggestions that are optional.
Congrats on the first PR here 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, Snowflake-manager requires secrets (Snowflake credentials) to be stored in the system's environment variables (e.g.,
.bash_profile). So, if working with different setups that require different credentials, the user had to comment out credentials, whenever switching between setups.Changes
inspector.py: If the Snowflake credentials are not stored as part of the system's environment variables, the previous cursor definition resulted in an exception, because it tried to connect to Snowflake, in absence of valid credentialsChecklist
pytest -vvblack .