Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

Adding integration tests#44

Merged
lpillmann merged 7 commits intomainfrom
adding-integration-tests
Jun 23, 2025
Merged

Adding integration tests#44
lpillmann merged 7 commits intomainfrom
adding-integration-tests

Conversation

@i-wagner
Copy link
Copy Markdown
Contributor

Description

This PR implements a basic framework for integration tests that can be run against snowflake-manager

Changes

  • Adding fixture for Snowflake connection/cursor
  • Updating GitHub workflow so that it pulls env variables, required for connecting to Snowflake
  • Adding integration tests for ddl and connection

Checklist

  • My pull request represents one logical piece of work
  • My commits are related to the pull request and look clean
  • I tested my changes locally with pytest -vv
  • I formatted my code with black .

@i-wagner i-wagner requested a review from lpillmann June 20, 2025 13:27
Copy link
Copy Markdown
Collaborator

@lpillmann lpillmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very good to me!

As we discussed, this is an important step that sets the foundation for integration tests. With these changes we can easily add new test scenarios and expand the coverage as needed 🎉

I noticed the automated tests failed and looks like the credentials are missing somehow. Good to merge after it is solved imo :)

@lpillmann lpillmann merged commit 0247c41 into main Jun 23, 2025
1 check passed
@lpillmann lpillmann deleted the adding-integration-tests branch June 23, 2025 14:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants