chore: drop synchronize trigger, add ready_for_review + @claude review#25
chore: drop synchronize trigger, add ready_for_review + @claude review#25
Conversation
Aligns with Gemma-Analytics/.github PR #20: - Drops synchronize to stop re-reviewing on every push - Adds ready_for_review for draft→ready transitions - Adds issue_comment trigger + job if-gate for @claude review comments - Adds !startsWith negation in claude.yml to route @claude review to the review workflow, not the generic responder
| on: | ||
| pull_request: | ||
| types: [opened, synchronize] | ||
| types: [opened, ready_for_review] |
There was a problem hiding this comment.
[BLOCKING] synchronize was removed from the trigger list, so the review workflow will no longer fire automatically when new commits are pushed to an open PR. The only way to re-trigger a review after a push is now to manually comment @claude review. This is almost certainly a regression — most teams expect the bot to re-review updated code without a manual prompt.
| types: [opened, ready_for_review] | |
| types: [opened, synchronize, ready_for_review] |
|
|
||
| jobs: | ||
| review: | ||
| if: | |
There was a problem hiding this comment.
[Suggestion] The if condition only checks github.event.issue.pull_request to confirm the comment is on a PR, but it does not guard against comments from untrusted actors (e.g. external contributors posting @claude review on a public repo). Consider adding github.event.sender.type == 'User' or gating on repo membership/collaborator status to avoid triggering a potentially costly (and secret-exposing) workflow from an arbitrary commenter.
Review SummaryThis PR splits the Claude review trigger from the general Claude comment trigger so that One blocking issue:
One suggestion:
Otherwise the change is straightforward and the |
|
Claude review cost: $0.1801 · 7 turns · 102s · |
Summary
Aligns with Gemma-Analytics/.github PR #20.
synchronizetrigger — Claude no longer re-reviews on every commit pushready_for_reviewtrigger — draft→ready transitions get reviewedissue_commenttrigger + job-levelif:gate for@claude reviewcomment!startsWith(body, '@claude review')negation inclaude.yml(where applicable) so@claude reviewroutes to the review workflow, not the generic responderMerge order
Merge Gemma-Analytics/.github#20 first.
🤖 Generated with Claude Code