-
Notifications
You must be signed in to change notification settings - Fork 32
Fixes, added isaac5 configurations #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @saihv, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the simulation environment's capabilities by integrating new Isaac5 configurations for a diverse range of robots and updating existing Airgen setups. It also refines the AI perception models used in notebooks by switching to Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several new configurations for isaac5 simulations and refactors many of the existing notebooks. The changes largely involve updating airgen client types from the generic VehicleClient to more specific ones like CVMoverClient, CarClient, and MultirotorClient, and switching the object detection model from GroundingDINO to OWLv2.
My review focuses on the correctness of these changes. While most of the refactoring appears correct and consistent, I've identified a couple of critical issues in the Isaac Sim notebooks where the removal of .run() calls will likely break their execution. Please see my detailed comments.
| "# Start the humanoid simulation\n", | ||
| "humanoidisaacsim_0.run()\n", | ||
| "\n", | ||
| "# Import necessary utilities for velocity control, logging, and timing\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The call to humanoidisaacsim_0.run() was removed, but it appears to be necessary for the simulation to start. Subsequent cells that interact with the simulation (e.g., humanoidisaacsim_0.locomotion.moveByVelocity(...)) will fail without it. Other Isaac Sim notebooks in the repository still include an explicit .run() call, suggesting it's still necessary. Please restore this call to ensure the notebook functions correctly. The cell's code should be:
# Start the humanoid simulation
humanoidisaacsim_0.run()
# Import necessary utilities for velocity control, logging, and timing
from grid.utils.types import Velocity
from grid.utils import log
import time| "obj = \"forklift\"\n", | ||
| "\n", | ||
| "humanoidisaacsim_0.run()" | ||
| "obj = \"forklift\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The call to humanoidisaacsim_0.run() has been removed from this cell. The next cell in the notebook calls humanoidisaacsim_0.getImage(...), which will likely fail if the simulation has not been started. Please restore the humanoidisaacsim_0.run() call to ensure the notebook executes correctly.
"obj = \"forklift\"\n",
"\n",
"humanoidisaacsim_0.run()"
No description provided.