Skip to content

Conversation

@saihv
Copy link
Contributor

@saihv saihv commented Jan 4, 2026

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @saihv, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the simulation environment's capabilities by integrating new Isaac5 configurations for a diverse range of robots and updating existing Airgen setups. It also refines the AI perception models used in notebooks by switching to OWLv2 and improves code clarity and type specificity by transitioning from generic VehicleClient to more specialized client types. These changes aim to enhance the flexibility and robustness of the simulation and data generation workflows.

Highlights

  • New Isaac5 Configurations: Several new Isaac5 simulation configurations have been added for various robotic platforms, including Franka, G1 humanoid, Rizon, Spot-like, and UR5e robots, primarily for tabletop and warehouse environments.
  • Airgen Configuration Updates: A new Airgen configuration for a legged robot (UnitreeGo2) has been introduced, and the scene for the existing multi-drone configuration has been updated from 'electric_central' to 'nordic_forest'.
  • AI Model Integration: The object detection model in several AI-related notebooks has been updated from GroundingDINO to OWLv2, enhancing perception capabilities.
  • Client Type Refinement in Notebooks: Various notebooks have been updated to use more specific client types (e.g., CarClient, MultirotorClient, CVMoverClient) instead of the generic VehicleClient, improving type safety and clarity.
  • Isaac Sim Notebook Simplification: Explicit run() calls have been removed from Isaac Sim notebooks, suggesting a streamlined or automated simulation startup process.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several new configurations for isaac5 simulations and refactors many of the existing notebooks. The changes largely involve updating airgen client types from the generic VehicleClient to more specific ones like CVMoverClient, CarClient, and MultirotorClient, and switching the object detection model from GroundingDINO to OWLv2.

My review focuses on the correctness of these changes. While most of the refactoring appears correct and consistent, I've identified a couple of critical issues in the Isaac Sim notebooks where the removal of .run() calls will likely break their execution. Please see my detailed comments.

"# Start the humanoid simulation\n",
"humanoidisaacsim_0.run()\n",
"\n",
"# Import necessary utilities for velocity control, logging, and timing\n",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The call to humanoidisaacsim_0.run() was removed, but it appears to be necessary for the simulation to start. Subsequent cells that interact with the simulation (e.g., humanoidisaacsim_0.locomotion.moveByVelocity(...)) will fail without it. Other Isaac Sim notebooks in the repository still include an explicit .run() call, suggesting it's still necessary. Please restore this call to ensure the notebook functions correctly. The cell's code should be:

# Start the humanoid simulation
humanoidisaacsim_0.run()

# Import necessary utilities for velocity control, logging, and timing
from grid.utils.types import Velocity
from grid.utils import log
import time

"obj = \"forklift\"\n",
"\n",
"humanoidisaacsim_0.run()"
"obj = \"forklift\""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The call to humanoidisaacsim_0.run() has been removed from this cell. The next cell in the notebook calls humanoidisaacsim_0.getImage(...), which will likely fail if the simulation has not been started. Please restore the humanoidisaacsim_0.run() call to ensure the notebook executes correctly.

    "obj = \"forklift\"\n",
    "\n",
    "humanoidisaacsim_0.run()"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants