Skip to content

Support nullable download timeout option #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JusterZhu merged 1 commit into from
Jan 7, 2026
Merged

Support nullable download timeout option #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified src/c#/GeneralUpdate.ClientCore/GeneralClientBootstrap.cs
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion src/c#/GeneralUpdate.Common/Internal/Bootstrap/UpdateOption.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ private class UpdateOptionPool : ConstantPool
/// <summary>
/// Timeout period (unit: second). If this parameter is not specified, the default timeout period is 30 seconds.
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment states the default timeout period is 30 seconds, but the actual default value used throughout the codebase is 60 seconds. The comment should be updated to match the implementation.

Suggested change
/// Timeout period (unit: second). If this parameter is not specified, the default timeout period is 30 seconds.
/// Timeout period (unit: second). If this parameter is not specified, the default timeout period is 60 seconds.

Copilot uses AI. Check for mistakes.
/// </summary>
public static readonly UpdateOption<int> DownloadTimeOut = ValueOf<int>("DOWNLOADTIMEOUT");
public static readonly UpdateOption<int?> DownloadTimeOut = ValueOf<int?>("DOWNLOADTIMEOUT");

/// <summary>
/// Whether to enable the driver upgrade function.
Expand Down
3 changes: 1 addition & 2 deletions src/c#/GeneralUpdate.Core/GeneralUpdateBootstrap.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,7 @@ private void ApplyRuntimeOptions()
{
_configInfo.Encoding = GetOption(UpdateOption.Encoding) ?? Encoding.Default;
_configInfo.Format = GetOption(UpdateOption.Format) ?? Format.ZIP;
var downloadTimeoutOption = GetOption(UpdateOption.DownloadTimeOut);
_configInfo.DownloadTimeOut = downloadTimeoutOption ?? 60;
_configInfo.DownloadTimeOut = GetOption(UpdateOption.DownloadTimeOut) ?? 60;
_configInfo.DriveEnabled = GetOption(UpdateOption.Drive) ?? false;
_configInfo.PatchEnabled = GetOption(UpdateOption.Patch) ?? true;
}
Expand Down
Loading