-
Notifications
You must be signed in to change notification settings - Fork 0
FE <-> BE: Search integration #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d73e3fa to
7302c91
Compare
|
ok just a few things on the backend search integration:
|
danctila
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok just a few things on the backend search integration:
-
i can't get the event results to show up but this might be a problem with my data - lmk if it works for you
-
Movie results: can you replace the movie poster with the exact component used in the movie for you page
-
Post results: the component mapping has to change for the two post types long + short. See how this is done in the movie chosen screen and rec by friends screen - this is basically the mapping:
- ReviewPost.tsx is for a long post with stars
- PicturePost.tsx is for short post with pic(s)
- TextPost.tsx is for short post without pic
Also make sure to fix the type issues in frontend (from ci):
Run cd frontend
Error: app/profilePage/user/[userId].tsx(49,58): error TS2554: Expected 1 arguments, but got 2.
Error: app/profilePage/user/[userId].tsx(52,19): error TS2339: Property 'find' does not exist on type 'UserSearchResponse'.
Error: app/profilePage/user/[userId].tsx(52,25): error TS7006: Parameter 'u' implicitly has an 'any' type.
Error: app/profilePage/user/[userId].tsx(53,11): error TS7053: Element implicitly has an 'any' type because expression of type '0' can't be used to index type 'UserSearchResponse'.
Property '0' does not exist on type 'UserSearchResponse'.
Error: screen/SearchScreen.tsx(62,50): error TS2554: Expected 1 arguments, but got 2.
Error: screen/SearchScreen.tsx(65,19): error TS2339: Property 'find' does not exist on type 'UserSearchResponse'.
Error: screen/SearchScreen.tsx(65,25): error TS7006: Parameter 'u' implicitly has an 'any' type.
Error: screen/SearchScreen.tsx(66,11): error TS7053: Element implicitly has an 'any' type because expression of type '0' can't be used to index type 'UserSearchResponse'.
Property '0' does not exist on type 'UserSearchResponse'.
Error: Process completed with exit code 2.
d862ce3 to
d528806
Compare
…arily change schema.prisma but i did it locally
f70444b to
f055aad
Compare




Description
search results, hooked up to backend 😩
Link to Ticket
Please include a summary of the changes and the related issue. Please also
include relevant motivation, context, and images!
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. If they are unit
tests, provide the file name the tests are in. If they are not unit tests,
describe how you tested the change.
Checklist