Skip to content

Conversation

@aamogh16
Copy link
Contributor

@aamogh16 aamogh16 commented Dec 4, 2025

Description

search results, hooked up to backend 😩

Link to Ticket

Please include a summary of the changes and the related issue. Please also
include relevant motivation, context, and images!

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. If they are unit
tests, provide the file name the tests are in. If they are not unit tests,
describe how you tested the change.

Checklist

  • I have performed a self-review of my code
  • I have reached out to another developer to review my code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@aamogh16
Copy link
Contributor Author

aamogh16 commented Dec 4, 2025

Movie Search:
image

Posts Search:
image

Event Search (no results in backend i think)
image

User Search:
image

@danctila danctila linked an issue Dec 4, 2025 that may be closed by this pull request
2 tasks
@aamogh16 aamogh16 force-pushed the frontend/search-results branch from d73e3fa to 7302c91 Compare December 5, 2025 04:59
@danctila
Copy link
Contributor

danctila commented Dec 5, 2025

ok just a few things on the backend search integration:

  • i can't get the event results to show up but this might be a problem with my data - lmk if it works for you

  • Movie results: can you replace the movie poster with the exact component used in the movie for you page

  • Post results: the component mapping has to change for the two post types long + short. See how this is done in the movie chosen screen and rec by friends screen - this is basically the mapping:

    • ReviewPost.tsx is for a long post with stars
    • PicturePost.tsx is for short post with pic(s)
    • TextPost.tsx is for short post without pic

    Also make sure to fix the type issues in frontend (from ci):

Run cd frontend
Error: app/profilePage/user/[userId].tsx(49,58): error TS2554: Expected 1 arguments, but got 2.
Error: app/profilePage/user/[userId].tsx(52,19): error TS2339: Property 'find' does not exist on type 'UserSearchResponse'.
Error: app/profilePage/user/[userId].tsx(52,25): error TS7006: Parameter 'u' implicitly has an 'any' type.
Error: app/profilePage/user/[userId].tsx(53,11): error TS7053: Element implicitly has an 'any' type because expression of type '0' can't be used to index type 'UserSearchResponse'.
 Property '0' does not exist on type 'UserSearchResponse'.
Error: screen/SearchScreen.tsx(62,50): error TS2554: Expected 1 arguments, but got 2.
Error: screen/SearchScreen.tsx(65,19): error TS2339: Property 'find' does not exist on type 'UserSearchResponse'.
Error: screen/SearchScreen.tsx(65,25): error TS7006: Parameter 'u' implicitly has an 'any' type.
Error: screen/SearchScreen.tsx(66,11): error TS7053: Element implicitly has an 'any' type because expression of type '0' can't be used to index type 'UserSearchResponse'.
 Property '0' does not exist on type 'UserSearchResponse'.
Error: Process completed with exit code 2.

Copy link
Contributor

@danctila danctila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok just a few things on the backend search integration:

  • i can't get the event results to show up but this might be a problem with my data - lmk if it works for you

  • Movie results: can you replace the movie poster with the exact component used in the movie for you page

  • Post results: the component mapping has to change for the two post types long + short. See how this is done in the movie chosen screen and rec by friends screen - this is basically the mapping:

    • ReviewPost.tsx is for a long post with stars
    • PicturePost.tsx is for short post with pic(s)
    • TextPost.tsx is for short post without pic

    Also make sure to fix the type issues in frontend (from ci):

Run cd frontend
Error: app/profilePage/user/[userId].tsx(49,58): error TS2554: Expected 1 arguments, but got 2.
Error: app/profilePage/user/[userId].tsx(52,19): error TS2339: Property 'find' does not exist on type 'UserSearchResponse'.
Error: app/profilePage/user/[userId].tsx(52,25): error TS7006: Parameter 'u' implicitly has an 'any' type.
Error: app/profilePage/user/[userId].tsx(53,11): error TS7053: Element implicitly has an 'any' type because expression of type '0' can't be used to index type 'UserSearchResponse'.
 Property '0' does not exist on type 'UserSearchResponse'.
Error: screen/SearchScreen.tsx(62,50): error TS2554: Expected 1 arguments, but got 2.
Error: screen/SearchScreen.tsx(65,19): error TS2339: Property 'find' does not exist on type 'UserSearchResponse'.
Error: screen/SearchScreen.tsx(65,25): error TS7006: Parameter 'u' implicitly has an 'any' type.
Error: screen/SearchScreen.tsx(66,11): error TS7053: Element implicitly has an 'any' type because expression of type '0' can't be used to index type 'UserSearchResponse'.
 Property '0' does not exist on type 'UserSearchResponse'.
Error: Process completed with exit code 2.

@aamogh16 aamogh16 force-pushed the frontend/search-results branch 3 times, most recently from d862ce3 to d528806 Compare December 5, 2025 21:55
@aamogh16 aamogh16 force-pushed the frontend/search-results branch from f70444b to f055aad Compare December 5, 2025 22:28
@danctila danctila merged commit 46c259e into main Dec 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FE <-> BE: Search integration

3 participants