[EXPERIMENTAL] add ComFree solver#2625
Draft
Kashu7100 wants to merge 5 commits intoGenesis-Embodied-AI:mainfrom
Draft
[EXPERIMENTAL] add ComFree solver#2625Kashu7100 wants to merge 5 commits intoGenesis-Embodied-AI:mainfrom
Kashu7100 wants to merge 5 commits intoGenesis-Embodied-AI:mainfrom
Conversation
duburcqa
reviewed
Mar 31, 2026
Collaborator
There was a problem hiding this comment.
Remove this example entirely. It is irrelevant. There is no way to examplify a solver, that makes no sense.
duburcqa
reviewed
Mar 31, 2026
Collaborator
There was a problem hiding this comment.
Avoid allocating fields that are not necessary if comfree is used.
Collaborator
There was a problem hiding this comment.
And the other way around of course.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces an initial implementation of the ComFree (https://github.com/asu-iris/comfree_warp) solver to Genesis.
While the solver is functional, it currently exhibits high sensitivity to hyperparameter configurations, and as such, this implementation is not yet considered production-ready. The primary goal of this PR is to solicit feedback from the community regarding stability, performance, and any edge-case bugs that may have been overlooked.
Related Issue
Resolves Genesis-Embodied-AI/Genesis#
Motivation and Context
How Has This Been / Can This Be Tested?
Screenshots (if appropriate):
Checklist:
Submitting Code Changessection of CONTRIBUTING document.