Skip to content

Conversation

@subashtiwari1010
Copy link
Collaborator

Related tasks

Fixes #2214

Describe this PR

This PR changes the position of displaying the spinner and put it outside the create new dataset button.
image

@gemini-code-assist
Copy link

Summary of Changes

Hello @subashtiwari1010, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a UI/UX refinement by adjusting the visual presentation of a loading spinner associated with the 'Create new dataset' button. The change ensures the spinner is positioned externally to the button, preventing potential layout issues within the button itself and providing a cleaner visual cue during data creation.

Highlights

  • Spinner Placement: The loading spinner, previously displayed inside the 'Create new dataset' button, has been moved to appear outside and alongside the button.
  • Layout Improvement: A generic div element wrapping the button has been replaced with a FlexBox component, configured to vertically center its children and add a small gap between them, ensuring proper alignment of the button and the spinner.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request moves the loading spinner from inside the 'Create New Dataset' button to a position next to it. This is a good UI improvement as it prevents the button from resizing when the loading process starts. The implementation correctly uses a FlexBox component to wrap the button and the spinner, ensuring they are properly aligned. The changes are clean, effective, and achieve the desired outcome without introducing any issues.

@allyoucanmap allyoucanmap merged commit e406a02 into GeoNode:master Dec 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.0.x enhancement New feature or request master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create page spinner is greyed

2 participants