-
Notifications
You must be signed in to change notification settings - Fork 127
Allow possibility to override default resource filter form options #2307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(cherry picked from commit a3f32f3)
Summary of ChangesHello @dsuren1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the configurability of the resource catalog page by allowing external configurations to override or extend the default set of filter options. A key improvement is the introduction of logic to prevent and remove duplicate filter entries, ensuring that the displayed filter list remains unique and functional. This change provides more control over the user interface and improves the robustness of the filter management system. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a mechanism to override default filter options and remove duplicates, which is a great enhancement. However, the current implementation has a potential issue where filter items without an id (such as dividers) would be unintentionally removed. I've provided a suggestion to address this by ensuring all items are handled correctly, preserving those without an ID while still deduplicating those with one.
Description
This PR allows overriding the default filter options and removing any duplicates from the resource catalog page's plugin configuration