Skip to content

Conversation

@anup39
Copy link
Member

@anup39 anup39 commented Jan 8, 2026

Fix the build due to missing private key in jsdoc.

@gemini-code-assist
Copy link

Summary of Changes

Hello @anup39, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a build failure stemming from malformed or incorrect JSDoc comments in the DocumentsFiltersForm.jsx file. The changes involve refining the JSDoc annotations to align with the component's functional nature and correct parameter naming, thereby ensuring a successful build process.

Highlights

  • JSDoc Correction: Addressed a build error by correcting JSDoc annotations within the DocumentsFiltersForm.jsx component.
  • Tag Refinement: Removed the @class and @example JSDoc tags, which were inappropriate for the functional component, and updated the @prop tag from cfg.fields to props.fields to accurately reflect the component's props.
  • Visibility Indication: Introduced the @private JSDoc tag to indicate the intended internal usage of the DocumentsFiltersForm component.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a build error caused by incorrect JSDoc annotations in the DocumentsFiltersForm component. The changes involve removing the @class tag from a functional component and correcting a prop definition. My review includes a suggestion to further improve the JSDoc for better accuracy by using the direct prop name.

* @name DocumentsFiltersForm
* @prop {object[]} cfg.fields array of filter object configurations
* @example
* @prop {object[]} props.fields array of filter object configurations

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better JSDoc accuracy and clarity, it's best to refer to the prop by its actual name as expected by the component. Since the prop is named fields, the documentation should reflect that instead of props.fields.

Suggested change
* @prop {object[]} props.fields array of filter object configurations
* @prop {object[]} fields array of filter object configurations

@anup39 anup39 requested a review from allyoucanmap January 8, 2026 14:50
@anup39 anup39 self-assigned this Jan 8, 2026
@allyoucanmap allyoucanmap merged commit 65e4e91 into GeoNode:master Jan 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants