Skip to content

Conversation

@giohappy
Copy link
Contributor

@giohappy giohappy commented Jan 9, 2026

This is required because we cannot publish to PyPi with a reference to a github tag

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jan 9, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @giohappy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request temporarily modifies the project's dependency management to utilize a self-published beta version of PyCSW. This adjustment is necessary to circumvent limitations with PyPI, which prevents direct references to GitHub tags in dependency declarations, thereby enabling successful package publication.

Highlights

  • Dependency Update: Replaced the direct Git reference for pycsw beta with a self-published geonode-pycsw==3.0.0b1 in both requirements.txt and setup.cfg.
  • PyPI Compatibility: This change is a temporary measure to allow publishing to PyPI, which does not support direct Git tag references for dependencies.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@giohappy giohappy merged commit 9bb66db into 5.0.x Jan 9, 2026
4 checks passed
@giohappy giohappy deleted the 5.0.x_use_interim_pycsw_beta branch January 9, 2026 09:59
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly replaces a direct git dependency for pycsw with a self-published package, geonode-pycsw, in both requirements.txt and setup.cfg. This change is well-justified by the need to publish to PyPI. My review includes suggestions to add comments in both files to document the temporary nature of this dependency, which will improve long-term maintainability by providing context for future updates.


# geopython dependencies
git+https://github.com/geopython/pycsw.git@3.0.0-beta1#egg=pycsw
geonode-pycsw==3.0.0b1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability, consider adding a comment explaining that this is a temporary dependency and why it's being used. This will provide valuable context for future developers, ensuring the reason for this temporary package isn't lost over time.

# TODO: Revert to official pycsw package once version >= 3.0.0 is released on PyPI.
# This temporary package is used because git dependencies are not allowed for packages published to PyPI.
geonode-pycsw==3.0.0b1

pyproj<3.8.0
OWSLib==0.34.1
pycsw @ git+https://github.com/geopython/pycsw.git@3.0.0-beta1#egg=pycsw
geonode-pycsw==3.0.0b1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency and to aid future maintenance, please add a similar comment here explaining the temporary nature of this dependency. This ensures the context is available wherever the dependency is declared.

    # TODO: Revert to official pycsw package once version >= 3.0.0 is released on PyPI.
    # This temporary package is used because git dependencies are not allowed for packages published to PyPI.
    geonode-pycsw==3.0.0b1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants