Add macos 14 and only build macos 11 in mpi release#712
Add macos 14 and only build macos 11 in mpi release#712MFraters wants to merge 1 commit intoGeodynamicWorldBuilder:mainfrom
Conversation
0477611 to
6ae0556
Compare
|
16 out of the 132 tests have issues on mac 14 arm. It seems to me mostly either small difference in the output numbers, or some small difference in the computed position caused by round off error causing it to fall on the other side of a line. It may be possible to make some the tests less sensitive to these round off errors, but I am not sure it is the case for all of them. Another option is to disable these specific tests on arm testers. @gassmoeller @tjhei opinions? |
|
|
Disabling tests for ARM seems a bit problematic, what if they are actual bugs that only surface on arm architecture? Making the tests less sensitive to roundoff or understanding why they fail seems like the safer path (and may also have benefits for future x86 tests on new operating systems). It is more work though, and maybe not the highest priority? |
|
Do you use numdiff for comparing test output right now like we do for ASPECT? |
|
I would also separate Linux and osx testing. |
|
Thanks for the feedback. Yes, numdiff is being used. I will take the longer route than in this case, although it may take a bit before I have time to address this issue. |
6ae0556 to
8382ccf
Compare
Macos 14 is the latest release, and also a arm version. So it would be good to see how well the tester works for this.