refactor to have a geometry type for each feature.#800
Open
MFraters wants to merge 1 commit intoGeodynamicWorldBuilder:mainfrom
Open
refactor to have a geometry type for each feature.#800MFraters wants to merge 1 commit intoGeodynamicWorldBuilder:mainfrom
MFraters wants to merge 1 commit intoGeodynamicWorldBuilder:mainfrom
Conversation
3dcaabb to
85d8ce7
Compare
|
85d8ce7 to
14c636c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With @danieldouglas92 adding contours and @Minerallo adding gplates functionality to define the geometry of features, I thought it would be good to have a more generic way of dealing with different geometries.
This solution add the geometry type (e.g. coordinates, contours, gplate) to the name of the feature file (coninental_plate, mantle_layer, etc.) and the same for the class name. We still want the user to be able to chose a model and geometry type separately, also not to break backward compatibility.
I will try it out with a mock contours continental plate, to see if this actually works as expected, but comments are welcome if this is a reasonable approach or not. @danieldouglas92, @Minerallo, @gassmoeller, @tjhei.