Refactor of qgis2leaf_exec#29
Refactor of qgis2leaf_exec#29NathanW2 wants to merge 1 commit intoGeolicious:masterfrom NathanW2:refactor_exec
Conversation
- Break method into functions for each part. - Only open the index file once - Write files at end only - Use templates rather then string concat - Only loop the layers once. Filter vector layers at the start.
|
Hi Nathan . Thank you for this major update. As I am new in handling merges and github: what needs to be done next? Shall i embed your given guideline in a new major release by copying manually? Thanks for your guidance. Best regards, Riccardo |
|
Don't do anything yet. I will get it into a state where you can just press merge here on github and it will bring everything in for you. |
|
That sounds cool! In my last commit I added some more base layers, and some minor changes in the UI. But I'll take care of those changes! |
|
@NathanW2 Can I go on with development for other issues or is it better to wait for your pull request?! |
|
Go on. I will bring yours into my changes when I have some time. Should be On Wed, Apr 30, 2014 at 5:49 PM, Riccardo Klinger
|
|
Did this ever get committed/merged? I am working off current master, but guess it will be fundamentally changing once this is merged. |
|
No I never got time to come back to it and don't have a lot of time now.
|
|
@NathanW2 I'd like to try to improve the current code's string handling, as per this PR. As a Python beginner, can I ask one question? What is the difference between: "A string with a {name}".format(name = var_name) and: Template("A string with a {name}").substitute(name = var_name) In other words, what does the Template substitute() method offer over and above the simple string format() method? |
|
Hi Everyone. Is this ever going to be merged? |
4 participants
This request does a major refactor on the
qgis2leaf_execmethod. Changes are as follows.Note: This is not mergeable yet or fully working. Needs some more testing but more to show you what has been done so far.