[upstream PR #310] fix: examples in kalman_filter.py #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgePearse
added
from-upstream-pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream PR: rlabbe/filterpy#310
Author: Imported from upstream
Original Description
The code in the Kalman filter example was broken in multiple ways. There were syntax errors, array shape errors, and undefined name errors.
I think I've fixed them in a reasonable way. I've also added a seeded random number generator to make the example deterministic. The only thing I'm not sure about is when I define
dt = 1as a constant, and ifcvis the best name for theKalmanFilterinstance in this example. Perhapsfis better. Please advise.I'll also note that perhaps some of these examples might be better written as a doctest. The standard library doctest runner can be a bit annoying, but my xdoctest library works very well and would help ensure that all of the examples actually run.
I can convert this particular example if desired. Let me know.
Integration Notes