Skip to content

fix: update min version for TrailParticleOption and particle effect fixes #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicholasveronico merged 3 commits into from
Dec 27, 2024
Merged

fix: update min version for TrailParticleOption and particle effect fixes #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9d34d1
fix: allow cherry leaves to be directional
nicholasveronico Dec 26, 2024
6921ee7
fix: update min value for TrailParticleOption and add
nicholasveronico Dec 26, 2024
a58d747
feat: add PALE_OAK_LEAVES to ParticleEffect documentation
nicholasveronico Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/main/java/com/georgev22/particle/ParticleEffect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@
* <li>{@link #NAUTILUS}</li>
* <li>{@link #NOTE}</li>
* <li>{@link #OMINOUS_SPAWNING}</li>
* <li>{@link #PALE_OAK_LEAVES}</li>
* <li>{@link #PORTAL}</li>
* <li>{@link #RAID_OMEN}</li>
* <li>{@link #REDSTONE}</li>
Expand Down Expand Up @@ -310,7 +311,7 @@ public enum ParticleEffect {
* <li>Speed value: Doesn't influence the particle.</li>
* </ul>
*/
CHERRY_LEAVES(version -> version < 19.4 ? "NONE" : version < 20 ? "falling_cherry_leaves" : "cherry_leaves"),
CHERRY_LEAVES(version -> version < 19.4 ? "NONE" : version < 20 ? "falling_cherry_leaves" : "cherry_leaves", DIRECTIONAL),
/**
* In vanilla, this particle is displayed when an entity dies.
* <p>
Expand Down Expand Up @@ -903,6 +904,17 @@ public enum ParticleEffect {
* </ul>
*/
OMINOUS_SPAWNING(version -> version < 20.5 ? "NONE" : "ominous_spawning", DIRECTIONAL),
/**
* In vanilla, this particle is displayed falling off pale oak leaves
* in pale garden biomes.
* <p>
* <b>Information</b>:
* <ul>
* <li>Appearance: Gray leaf.</li>
* <li>Speed value: Doesn't influence the particle.</li>
* </ul>
*/
PALE_OAK_LEAVES(version -> version < 21.4 ? "NONE" : "pale_oak_leaves", DIRECTIONAL),
/**
* In vanilla, this particle is randomly displayed by nether
* portal, endermen, ender chests, dragon eggs, endermites and end
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/mappings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@
},
{
"name": "TrailParticleOption",
"min": 19,
"min": 21.3,
"max": 99,
"mappings": [
{
Expand Down
Loading