Open
Conversation
Contributor
|
@vedi does |
Contributor
|
@vedi what’s the intention of the refactoring? The code is working perfectly fine the way it is now. It looks like you’re trying to model the python library against the js library that you have, but the code in this branch is not at all pythonic. If you do merge a refactor like this, we’d just go back to using our own version. It’s working in production today and is pythonic, which makes it easier to maintain. The changes you have here would also require that we make major changes to our systems to support the breaking changes that you’re introducing. So again, what’s the advantage of refactoring something that’s already well-written, pythonic, 100% tested, and working in production? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.